Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug: knip.jsonc has unnecessary fields #1163

Closed
3 tasks done
JoshuaKGoldberg opened this issue Dec 31, 2023 · 1 comment · Fixed by #1164
Closed
3 tasks done

🐛 Bug: knip.jsonc has unnecessary fields #1163

JoshuaKGoldberg opened this issue Dec 31, 2023 · 1 comment · Fixed by #1164
Assignees
@JoshuaKGoldberg
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(

Comments

@JoshuaKGoldberg
Copy link
Owner

JoshuaKGoldberg commented Dec 31, 2023 •
edited
Loading

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

knip.jsonc should be as simple as possible. 🧹

Actual

I don't think these are necessary?

create-typescript-app/knip.jsonc

Lines 5 to 7 in 7390c17

"src/guide/index.ts",
"src/initialize/index.ts",
"src/migrate/index.ts",

Additional Info

Also, "script" is not a dependency run by this project:

create-typescript-app/knip.jsonc

Line 11 in 7390c17

"ignoreDependencies": ["script"],

...but that gives Knip errors when I remove it. Filed on webpro-nl/knip#417.
@JoshuaKGoldberg JoshuaKGoldberg added type: bug Something isn't working :( status: accepting prs Please, send a pull request to resolve this! labels Dec 31, 2023
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Dec 31, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Dec 31, 2023
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Dec 31, 2023
@JoshuaKGoldberg
fix: removed unnecessary knip.jsonc entries (#1164)
51a426a 
## PR Checklist

- [x] Addresses an existing open issue: fixes #1163
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Removes the unnecessary entries.
@github-actions GitHub Actions
Copy link

🎉 This is included in version v1.52.4 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: removed unnecessary knip.jsonc entries JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg