🐛 Bug: Is CTA adding more checks than there are workflows for it?

[johnnyreilly]

Bug Report Checklist

• I have tried restarting my IDE and the issue persists.
• I have pulled the latest main branch of the repository.
• I have searched for related issues and found none that matched my issue.

Expected

Heya!

So I'm hacking away at my side project here: johnnyreilly/schemar#1

And I noticed on the PR that there were checks for workflows that I don't have in my repo; a bunch of the lint_knip / lint_markdown etc workflows

Given I don't have those in my repo, I was surprised they showed up in GitHub. Regrettably I can't remember if those workflow files originally existed or if I deleted them. (Makes me think it'd be handy to have a metadata file that shows how a project was initialised or something)

Actual

Additional Info

This might be user error; not sure.

[JoshuaKGoldberg]

Ah, yes, this is a bug. Good catch. Workflow files are created conditionally based on options:

create-typescript-app/src/steps/writing/creation/dotGitHub/createWorkflows.ts

Lines 119 to 120 in 01704e9

	...(!options.excludeLintKnip && {
	"lint-knip.yml": createWorkflowFile({

...but branch protection settings are all always created:

create-typescript-app/src/steps/initializeGitHubRepository/initializeBranchProtectionSettings.ts

Lines 26 to 31 in 70d6937

	required_status_checks: {
	checks: [
	{ context: "build" },
	{ context: "compliance" },
	{ context: "lint" },
	{ context: "lint_knip" },

The initializeBranchProtectionSettings function should be updated to only create branch protections needed per options. Thanks for filing!

[github-actions]

🎉 This is included in version v1.57.7 🎉

The release is available on:

• GitHub releases
• npm package (@latest dist-tag)

Cheers! 📦🚀