Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug: Typo in generated .github/DEVELOPMENT.md lint paragraph with --base common #1174

Closed
3 tasks done
JoshuaKGoldberg opened this issue Jan 3, 2024 · 1 comment · Fixed by #1176
Closed
3 tasks done

🐛 Bug: Typo in generated .github/DEVELOPMENT.md lint paragraph with --base common #1174

JoshuaKGoldberg opened this issue Jan 3, 2024 · 1 comment · Fixed by #1176
Labels
good first issue Good for newcomers, please hop on! status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

In the minimal/common base, the mention of linting shouldn't have typos.

Actual

From https://github.com/johnnyreilly/schemar/blob/e25a63364a9d8b36c3da27558075c81d6d8152c7/.github/DEVELOPMENT.md?plain=1#L41, note the extra ) parenthesis:

ESLint is used with with typescript-eslint) to lint JavaScript and TypeScript source files.

[ESLint](https://eslint.org) is used with with [typescript-eslint](https://typescript-eslint.io)) to lint JavaScript and TypeScript source files.

Additional Info

This bit of templating comes from:

create-typescript-app/src/steps/writing/creation/dotGitHub/createDevelopment.ts

Line 70 in 7f1350e

`- \`pnpm lint\` ([ESLint](https://eslint.org) with [typescript-eslint](https://typescript-eslint.io)): Lints JavaScript and TypeScript source files`,

@JoshuaKGoldberg JoshuaKGoldberg added good first issue Good for newcomers, please hop on! type: bug Something isn't working :( status: accepting prs Please, send a pull request to resolve this! labels Jan 3, 2024
@johnnyreilly johnnyreilly mentioned this issue Jan 3, 2024
Merged
3 tasks
JoshuaKGoldberg pushed a commit that referenced this issue Jan 3, 2024
@johnnyreilly
fix: markdown typo - the case of the extra ')' (#1176)
a76cea9 
<!-- 👋 Hi, thanks for sending a PR to create-typescript-app! 💖.
Please fill out all fields below and make sure each item is true and [x]
checked.
Otherwise we may not be able to review your PR. -->

## PR Checklist

- [x] Addresses an existing open issue: fixes #1174
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

One char PRs a speciality 😉
oven-sh/bun#2175
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2024

🎉 This is included in version v1.52.6 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers, please hop on! status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: markdown typo - the case of the extra ')' JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg