Skip to content

🛠 Tooling: Remove knip.jsonc "ignoreDependencies": ["script"], #1177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
JoshuaKGoldberg opened this issue Jan 3, 2024 · 1 comment · Fixed by #1178
Closed
3 tasks done

🛠 Tooling: Remove knip.jsonc "ignoreDependencies": ["script"], #1177

JoshuaKGoldberg opened this issue Jan 3, 2024 · 1 comment · Fixed by #1178
Assignees
@JoshuaKGoldberg
Labels
area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! type: cleanup Tech debt or other code/repository cleanups

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

Per webpro-nl/knip#417, the following will be unnecessary once Knip is bumped to 3.10.0:

create-typescript-app/knip.jsonc

Lines 5 to 6 in 51a426a

// https://github.com/webpro/knip/issues/417
"ignoreDependencies": ["script"],

Additional Info

No response
@JoshuaKGoldberg JoshuaKGoldberg added area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! type: cleanup Tech debt or other code/repository cleanups labels Jan 3, 2024
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Jan 3, 2024
This was referenced Jan 3, 2024
Merged
Merged
JoshuaKGoldberg added a commit that referenced this issue Jan 3, 2024
@JoshuaKGoldberg
chore: bump Knip to 3.10.0 (#1178)
ce0d56a 
## PR Checklist

- [x] Addresses an existing open issue: fixes #1177
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Bumps Knip and removes the now-unnecessary ignore.
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 6, 2024

🎉 This is included in version v1.52.7 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! type: cleanup Tech debt or other code/repository cleanups
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: bump Knip to 3.10.0 JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg