Skip to content

🛠 Tooling: knip.jsonc adds unnecessary diffs for line breaks #1179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
JoshuaKGoldberg opened this issue Jan 3, 2024 · 1 comment · Fixed by #1180
Closed
3 tasks done

🛠 Tooling: knip.jsonc adds unnecessary diffs for line breaks #1179

JoshuaKGoldberg opened this issue Jan 3, 2024 · 1 comment · Fixed by #1180
Assignees
@JoshuaKGoldberg
Labels
area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! type: cleanup Tech debt or other code/repository cleanups

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

Following #1178, this is the knip.jsonc migration test snapshot:

create-typescript-app/script/__snapshots__/migrate-test-e2e.js.snap

Lines 199 to 216 in ce0d56a

exports[`expected file changes > knip.jsonc 1`] = `
"--- a/knip.jsonc
+++ b/knip.jsonc
@@ ... @@
{
"$schema": "https://unpkg.com/knip@latest/schema.json",
- "entry": ["src/index.ts!", "script/*e2e.js"],
- "ignoreBinaries": ["gh"],
- "ignoreExportsUsedInFile": {
- "interface": true,
- "type": true
- },
- "project": ["src/**/*.ts!", "script/**/*.js"]
+ "entry": ["src/index.ts!"],
+ "ignoreExportsUsedInFile": { "interface": true, "type": true },
+ "project": ["src/**/*.ts!"]
}"
`;

It'd be smaller if the knip.jsonc in the repo used a single line for ignoreExportsUsedInFile. I shall bend to the will of Prettier.

Additional Info

No response
@JoshuaKGoldberg JoshuaKGoldberg added area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! type: cleanup Tech debt or other code/repository cleanups labels Jan 3, 2024
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Jan 3, 2024
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Jan 3, 2024
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Jan 3, 2024
@JoshuaKGoldberg
chore: align knip.jsonc lines to Prettier (#1180)
a8f6b23 
## PR Checklist

- [x] Addresses an existing open issue: fixes #1179
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Puts the `ignoreExportsUsedInFile` properties all on one line, to reduce
snapshot size.
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 6, 2024

🎉 This is included in version v1.52.7 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! type: cleanup Tech debt or other code/repository cleanups
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: align knip.jsonc lines to Prettier JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg