Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🛠 Tooling: Bump Node version used in CI from 18 to 20 #1204

Closed
3 tasks done
JoshuaKGoldberg opened this issue Jan 6, 2024 · 1 comment · Fixed by #1233
Closed
3 tasks done

🛠 Tooling: Bump Node version used in CI from 18 to 20 #1204

JoshuaKGoldberg opened this issue Jan 6, 2024 · 1 comment · Fixed by #1233
Labels
area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! type: cleanup Tech debt or other code/repository cleanups

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

This repo uses Node 18 in CI right now:

https://github.com/JoshuaKGoldberg/all-contributors-auto-action/blob/95d5e93299adb73b75c909d5fedccd467ab8b8ec/.github/actions/prepare/action.yml#L8-L11

I'd initially kept it at 18 rather than the newer 20 so that backwards compatibility with older Node features is tested in CI. But that issue has never come up

Additional Info

No response
@JoshuaKGoldberg JoshuaKGoldberg added area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! type: cleanup Tech debt or other code/repository cleanups labels Jan 6, 2024
This was referenced Jan 6, 2024
Merged
Merged
JoshuaKGoldberg added a commit that referenced this issue Jan 12, 2024
@JoshuaKGoldberg
feat: bump CI version of Node to 20 (#1233)
1f395f5 
## PR Checklist

- [x] Addresses an existing open issue: fixes #1204
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Swaps the number from 18 to 20. Straightforward.
@github-actions GitHub Actions
Copy link

🎉 This is included in version v1.54.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! type: cleanup Tech debt or other code/repository cleanups
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: bump CI version of Node to 20 JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg