Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🛠 Tooling: Use explicit .json extension for .prettierrc instead of Prettier override #1214

Closed
3 tasks done
JoshuaKGoldberg opened this issue Jan 9, 2024 · 1 comment · Fixed by #1215
Closed
3 tasks done

🛠 Tooling: Use explicit .json extension for .prettierrc instead of Prettier override #1214

JoshuaKGoldberg opened this issue Jan 9, 2024 · 1 comment · Fixed by #1215
Assignees
@JoshuaKGoldberg
Labels
area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! type: cleanup Tech debt or other code/repository cleanups
Milestone
General Simplific...

Comments

@JoshuaKGoldberg
Copy link
Owner

JoshuaKGoldberg commented Jan 9, 2024 •
edited
Loading

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

Right now, the Prettier config specifies exactly two overrides:

https://github.com/JoshuaKGoldberg/create-typescript-app/blob/a6feabdf3cb7aa525167168652a17bd2c3de2330/.prettierrc#L3-L6

There's only one *.rc file that isn't .nvmrc: .prettierrc itself. But Prettier supports explicit config file formats. Let's switch to .prettierrc to .prettierrc.json.

As for .nvmrc, prettier/prettier#15898 tracks Prettier supporting it natively. I'll need to leave that remaining override in for now.

Additional Info

No response
@JoshuaKGoldberg JoshuaKGoldberg added area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! type: cleanup Tech debt or other code/repository cleanups labels Jan 9, 2024
@JoshuaKGoldberg JoshuaKGoldberg added this to the General Simplification milestone Jan 9, 2024
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Jan 9, 2024
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Jan 9, 2024
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Jan 9, 2024
@JoshuaKGoldberg
feat: rename .prettierrc to .prettierrc.json (#1215)
07c0abc 
## PR Checklist

- [x] Addresses an existing open issue: fixes #1214
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Renames the file, removes one of its overrides, and updates templates.
@github-actions GitHub Actions
Copy link

🎉 This is included in version v1.54.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! type: cleanup Tech debt or other code/repository cleanups
Projects
None yet
Milestone
General Simplification
Development

Successfully merging a pull request may close this issue.

feat: rename .prettierrc to .prettierrc.json JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg