-
-
Notifications
You must be signed in to change notification settings - Fork 80
🐛 Bug: eslint does not report problems on tasks.json
in VS Code
#1219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@all-contributors please add @danvk for bug.
|
I've put up a pull request to add @danvk! 🎉 I couldn't determine any contributions to add, did you specify any contributions? |
Adds @danvk as a contributor for bug. This was requested by JoshuaKGoldberg [in this comment](#1219 (comment)) --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Hmm, looks like using Worst case scenario, we can go back to |
Good news, looks like this was resolved by microsoft/vscode-eslint#1787! I tried out a straightforward rule violation locally by adding a trailing comma in $ npx eslint .vscode/tasks.json
/Users/josh/repos/create-typescript-app/.vscode/tasks.json
7:17 error Unexpected trailing comma jsonc/comma-dangle
✖ 1 problem (1 error, 0 warnings)
1 error and 0 warnings potentially fixable with the `--fix` option. 🚀. |
Bug Report Checklist
main
branch of the repository.Expected
I created a new repo yesterday using
create-typescript-app
using the "everything" setting (woo!). I set up a few tasks in VS Code'stasks.json
and pushed a PR, at which point I noticed that I was getting some eslint errors because of unsorted keys in mytasks.json
.These were reported via GitHub Actions CI and when I run
pnpm lint
, but they were not reported in VS Code like lint errors in.ts
files are.Actual
I would expect eslint issues in
tasks.json
to be reported in VS Code (so that I can quick fix them!).Additional Info
I noticed that
"json"
is in theeslint.probe
list in.code/settings.json
, but maybe it also needs to be told about JSON files some other place?Here's the PR and repo: danvk/gravlax#3
The text was updated successfully, but these errors were encountered: