Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🛠 Tooling: Remove package.json changes from end-to-end migration snapshot #1226

Closed
3 tasks done
JoshuaKGoldberg opened this issue Jan 9, 2024 · 1 comment · Fixed by #1252
Closed
3 tasks done

🛠 Tooling: Remove package.json changes from end-to-end migration snapshot #1226

JoshuaKGoldberg opened this issue Jan 9, 2024 · 1 comment · Fixed by #1252
Labels
area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! type: cleanup Tech debt or other code/repository cleanups
Milestone
Simpler Snapshots

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

I'd hoped that #1220 -> #1223 would eliminate all remaining end-to-end migration test snapshot diffs for package.json. But a few still exist:

create-typescript-app/script/__snapshots__/migrate-test-e2e.js.snap

Lines 170 to 191 in c4025fa

exports[`expected file changes > package.json 1`] = `
"--- a/package.json
+++ b/package.json
@@ ... @@
"scripts": {
"build": "tsup",
"format": "prettier \\"**/*\\" --ignore-unknown",
- "initialize": "tsx ./bin/index.js --mode initialize",
"lint": "eslint . .*js --max-warnings 0",
"lint:knip": "knip",
"lint:md": "markdownlint \\"**/*.md\\" \\".github/**/*.md\\" --rules sentences-per-line",
@@ ... @@
"prepare": "husky install",
"should-semantic-release": "should-semantic-release --verbose",
"test": "vitest",
- "test:create": "node script/create-test-e2e.js",
- "test:initialize": "node script/initialize-test-e2e.js",
- "test:migrate": "vitest run -r script/",
"tsc": "tsc"
},
"lint-staged": {"
`;

Accepting PRs to make it so the end-to-end test doesn't remove those package.json scripts.

Additional Info

No response
@JoshuaKGoldberg JoshuaKGoldberg added area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! type: cleanup Tech debt or other code/repository cleanups labels Jan 9, 2024
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Jan 16, 2024
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Jan 16, 2024
@JoshuaKGoldberg
fix: preserve existing package.json scripts (#1252)
fc4e7e5 
## PR Checklist

- [x] Addresses an existing open issue: fixes #1226
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Changes `package.json` creation to preserve any existing `scripts`.
@github-actions GitHub Actions
Copy link

🎉 This is included in version v1.54.1 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! type: cleanup Tech debt or other code/repository cleanups
Projects
None yet
Milestone
Simpler Snapshots
Development

Successfully merging a pull request may close this issue.

fix: preserve existing package.json scripts JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg