Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🛠 Tooling: Create end-to-end test failures on main: trailing commas in tsconfig.json #1257

Closed
3 tasks done
JoshuaKGoldberg opened this issue Jan 17, 2024 · 1 comment · Fixed by #1258
Closed
3 tasks done

🛠 Tooling: Create end-to-end test failures on main: trailing commas in tsconfig.json #1257

JoshuaKGoldberg opened this issue Jan 17, 2024 · 1 comment · Fixed by #1258
Assignees
@JoshuaKGoldberg
Labels
area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

Example failure from https://github.com/JoshuaKGoldberg/create-typescript-app/actions/runs/7551367303/job/20558523924:

/home/runner/work/create-typescript-app/create-typescript-app/create-typescript-app/tsconfig.json
Error:   14:21  error  Unexpected trailing comma  jsonc/comma-dangle
Error:   16:20  error  Unexpected trailing comma  jsonc/comma-dangle

Additional Info

This is from prettier/prettier#15831 adding in a jsonc parser to Prettier.
@JoshuaKGoldberg JoshuaKGoldberg added type: bug Something isn't working :( area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! labels Jan 17, 2024
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Jan 17, 2024
This was referenced Jan 17, 2024
Closed
Merged
JoshuaKGoldberg added a commit that referenced this issue Jan 17, 2024
@JoshuaKGoldberg
fix: disable jsonc/comma-dangle (#1258)
ed53de1 
## PR Checklist

- [x] Addresses an existing open issue: fixes #1257
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Disables the `jsonc/comma-dangle` rule altogether so as to not conflict
with Prettier. I suppose if any tool doesn't support trailing commas in
a file, it'll report that directly. And most tools generally support
jsonc anyway. 🤷
@github-actions GitHub Actions
Copy link

🎉 This is included in version v1.54.4 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: disable jsonc/comma-dangle JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg