Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable jsonc/comma-dangle #1258

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Conversation

JoshuaKGoldberg
Copy link
Owner

PR Checklist

Overview

Disables the jsonc/comma-dangle rule altogether so as to not conflict with Prettier. I suppose if any tool doesn't support trailing commas in a file, it'll report that directly. And most tools generally support jsonc anyway. 🤷

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (41ab495) 94.81% compared to head (e493a0a) 94.81%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1258   +/-   ##
=======================================
  Coverage   94.81%   94.81%           
=======================================
  Files         104      104           
  Lines        5807     5808    +1     
  Branches      492      492           
=======================================
+ Hits         5506     5507    +1     
  Misses        300      300           
  Partials        1        1           
Flag Coverage Δ
create 70.09% <100.00%> (+<0.01%) ⬆️
initialize 42.23% <0.00%> (-0.01%) ⬇️
migrate 69.90% <100.00%> (+<0.01%) ⬆️
unit 75.60% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoshuaKGoldberg JoshuaKGoldberg merged commit ed53de1 into main Jan 17, 2024
@JoshuaKGoldberg JoshuaKGoldberg deleted the eslint-jsonc-comma-dangle-off branch January 17, 2024 14:10
Copy link

🎉 This is included in version v1.54.4 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🛠 Tooling: Create end-to-end test failures on main: trailing commas in tsconfig.json
1 participant