Skip to content

🧪 Testing: Use a different repo name in end-to-end create test #1259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
JoshuaKGoldberg opened this issue Jan 17, 2024 · 1 comment · Fixed by #1260
Closed
3 tasks done

🧪 Testing: Use a different repo name in end-to-end create test #1259

JoshuaKGoldberg opened this issue Jan 17, 2024 · 1 comment · Fixed by #1260
Assignees
@JoshuaKGoldberg
Labels
area: testing Improving how the repository's tests are run and/or code is tested status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

The end-to-end test script for creation right now uses create-typescript-app as the new repo name:

create-typescript-app/script/create-test-e2e.js

Line 8 in 6774141

const repository = "create-typescript-app";

It'd be good to use a different name in case tooling accidentally uses create-typescript-app instead of the provided name.

Additional Info

No response
@JoshuaKGoldberg JoshuaKGoldberg added type: feature New enhancement or request status: accepting prs Please, send a pull request to resolve this! area: testing Improving how the repository's tests are run and/or code is tested labels Jan 17, 2024
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Jan 17, 2024
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Jan 17, 2024
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Jan 17, 2024
@JoshuaKGoldberg
test: switched repository name in e2e create test (#1260)
81fb3eb 
## PR Checklist

- [x] Addresses an existing open issue: fixes #1259
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Swaps the name. Straightforward.
@github-actions GitHub Actions
Copy link

🎉 This is included in version v1.55.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
area: testing Improving how the repository's tests are run and/or code is tested status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: switched repository name in e2e create test JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg