Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 Feature: Move .eslintignore into ESLint config #1261

Closed
3 tasks done
JoshuaKGoldberg opened this issue Jan 17, 2024 · 1 comment · Fixed by #1262
Closed
3 tasks done

🚀 Feature: Move .eslintignore into ESLint config #1261

JoshuaKGoldberg opened this issue Jan 17, 2024 · 1 comment · Fixed by #1262
Assignees
@JoshuaKGoldberg
Labels
status: accepting prs Please, send a pull request to resolve this! type: cleanup Tech debt or other code/repository cleanups type: feature New enhancement or request
Milestone
General Simplific...

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

Right now this template has two ESLint config-ish files:

  • .eslintignore
  • .eslintrc.cjs

...but the latter supports the former with ignorePatterns! We can reduce to just one file as an act of simplification.

Additional Info

No response
@JoshuaKGoldberg JoshuaKGoldberg added area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! type: cleanup Tech debt or other code/repository cleanups labels Jan 17, 2024
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Jan 17, 2024
@JoshuaKGoldberg JoshuaKGoldberg changed the title 🛠 Tooling: Move .eslintignore into ESLint config 🚀 Feature: Move .eslintignore into ESLint config Jan 17, 2024
@JoshuaKGoldberg JoshuaKGoldberg added type: feature New enhancement or request and removed area: tooling Managing the repository's maintenance labels Jan 17, 2024
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Jan 17, 2024
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Jan 17, 2024
@JoshuaKGoldberg
feat: move .eslintignore into .eslintrc.cjs ignorePatterns (#1262)
287bc46 
## PR Checklist

- [x] Addresses an existing open issue: fixes #1261
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Removes the `.eslintignore` file and its templating. Instead adds the
`ignorePatterns` entry in `.eslintrc.cjs` and its templates.

Also adds `.eslintignore` to the list of cleared unnecessary files.
@github-actions GitHub Actions
Copy link

🎉 This is included in version v1.55.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
status: accepting prs Please, send a pull request to resolve this! type: cleanup Tech debt or other code/repository cleanups type: feature New enhancement or request
Projects
None yet
Milestone
General Simplification
Development

Successfully merging a pull request may close this issue.

feat: move .eslintignore into .eslintrc.cjs ignorePatterns JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg