Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 Feature: Add prettier-plugin-sh #1263

Closed
3 tasks done
JoshuaKGoldberg opened this issue Jan 17, 2024 · 1 comment · Fixed by #1544
Closed
3 tasks done

🚀 Feature: Add prettier-plugin-sh #1263

JoshuaKGoldberg opened this issue Jan 17, 2024 · 1 comment · Fixed by #1544
Assignees
@JoshuaKGoldberg
Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

As of un-ts/prettier#340 -> un-ts/prettier#341, prettier-plugin-sh can work on .nvmrc. That means it can replace the last overrides in .prettierrc.json!

create-typescript-app/.prettierrc.json

Line 3 in 07c0abc

"overrides": [{ "files": ".nvmrc", "options": { "parser": "yaml" } }],

Let's add that in. It's also a generally useful plugin for expanding the range of file extensions / syntax Prettier will format.

Additional Info

No response
@JoshuaKGoldberg JoshuaKGoldberg added type: feature New enhancement or request status: accepting prs Please, send a pull request to resolve this! labels Jan 17, 2024
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Jan 17, 2024
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Jun 6, 2024
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Jun 6, 2024
@JoshuaKGoldberg
feat: add prettier-plugin-sh (#1544)
91a3701 
## PR Checklist

- [x] Addresses an existing open issue: fixes #1263
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Adds the plugin in, similar to the existing `prettier-plugin-curly` and
`prettier-plugin-packagejson` plugins.

💖
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2024

🎉 This is included in version v1.61.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add prettier-plugin-sh JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg