Skip to content

🛠 Tooling: Build failures on main for create and migrate end-to-end tests #1291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
3 tasks done
JoshuaKGoldberg opened this issue Feb 5, 2024 · 1 comment
Closed
3 tasks done
Assignees
Labels
area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(

Comments

@JoshuaKGoldberg
Copy link
Owner

JoshuaKGoldberg commented Feb 5, 2024

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

https://github.com/JoshuaKGoldberg/create-typescript-app/actions/runs/7777140942/job/21205100530 & https://github.com/JoshuaKGoldberg/create-typescript-app/actions/runs/7777140935/job/21205100766:

> [email protected] lint:knip /home/runner/work/create-typescript-app/create-typescript-app/testing-repository
> knip

The CJS build of Vite's Node API is deprecated. See https://vitejs.dev/guide/troubleshooting.html#vite-cjs-node-api-deprecated for more details.
Unused devDependencies (1)
lint-staged  package.json
 ELIFECYCLE  Command failed with exit code 1.
file:///home/runner/work/create-typescript-app/create-typescript-app/node_modules/.pnpm/[email protected]/node_modules/execa/lib/error.js:60
		error = new Error(message);
		        ^

Error: Command failed with exit code 1: pnpm run lint:knip

Hmm. The failures started in #1278, which was only merged because of #877.

Additional Info

No response

@JoshuaKGoldberg JoshuaKGoldberg added type: bug Something isn't working :( area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! labels Feb 5, 2024
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Feb 5, 2024
@JoshuaKGoldberg
Copy link
Owner Author

This was fixed in Knip. As of #1298 we're on Knip v5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Development

No branches or pull requests

1 participant