Skip to content

🐛 Bug: Renovate PRs are getting merged with failing migration test #877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
JoshuaKGoldberg opened this issue Sep 22, 2023 · 3 comments
Closed
3 tasks done

🐛 Bug: Renovate PRs are getting merged with failing migration test #877

JoshuaKGoldberg opened this issue Sep 22, 2023 · 3 comments
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(

Comments

@JoshuaKGoldberg
Copy link
Owner

JoshuaKGoldberg commented Sep 22, 2023 •
edited
Loading

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

PRs from bots should never be auto-merged if there's a failing build.

Actual

#870 was and broke main's end-to-end migration test job!

How?!

Additional Info

Looks like this also happened in #644.

Per renovatebot/renovate#1072 the GitHub status checks from those PRs should probably be checked. Maybe it's a GitHub issue?

Edit: example failing PR: #975.
@JoshuaKGoldberg JoshuaKGoldberg added type: bug Something isn't working :( status: accepting prs Please, send a pull request to resolve this! labels Sep 22, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Oct 20, 2023
Merged
3 tasks
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Oct 28, 2023
Merged
3 tasks
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Nov 28, 2023
Merged
3 tasks
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Dec 11, 2023
Merged
3 tasks
This was referenced Jan 6, 2024
Merged
Closed
Merged
@JoshuaKGoldberg
Copy link
Owner Author

Omg. @johnnyreilly you're right - I never set up the end-to-end tests as required for branch protections. Thank you!!

@JoshuaKGoldberg
Copy link
Owner Author

Added create, initialize, and migrate to the branch protections for the main branch. Let's hope that fixes things. I think it should!

@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Feb 5, 2024
Closed
3 tasks
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Mar 14, 2024
Merged
1 task
@JoshuaKGoldberg
Copy link
Owner Author

JoshuaKGoldberg commented Mar 14, 2024 •
edited
Loading

#1315 (comment)

@johnnyreilly I think your suggestion worked! This is blocked on the migration script failing. Yay! 🥳 thank you again!

@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Feb 13, 2025
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JoshuaKGoldberg