Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 Feature: Also delete existing Mocha options file in migration, if it exists #1372

Closed
2 tasks done
JoshuaKGoldberg opened this issue Mar 7, 2024 · 1 comment · Fixed by #1607
Closed
2 tasks done

🚀 Feature: Also delete existing Mocha options file in migration, if it exists #1372

JoshuaKGoldberg opened this issue Mar 7, 2024 · 1 comment · Fixed by #1607
Labels
good first issue Good for newcomers, please hop on! status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request

Comments

@JoshuaKGoldberg
Copy link
Owner

JoshuaKGoldberg commented Mar 7, 2024 •
edited
Loading

Bug Report Checklist

Overview

Right now, --mode migrate will attempt to delete any existing Jest config file:

create-typescript-app/src/steps/clearUnnecessaryFiles.ts

Line 9 in 592b0c8

...extensions("jest.config", "cjs", "js", "json", "mjs", "ts"),

Fun fact: the venerable Mocha test framework has config file support too! https://mochajs.org/#configuring-mocha-nodejs

Let's have files like .mocharc.js, .mocharc.yml, etc. be removed during migration too.

Additional Info

Other test frameworks -Ava, QUnit, etc.- could be migrated too. I'd welcome anybody using those to file a new issue requesting that as a feature.

Similar issue for Mocha: #1374
@JoshuaKGoldberg JoshuaKGoldberg added good first issue Good for newcomers, please hop on! type: feature New enhancement or request status: accepting prs Please, send a pull request to resolve this! labels Mar 7, 2024
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Mar 7, 2024
Closed
2 tasks
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Aug 7, 2024
Merged
3 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 7, 2024

🎉 This is included in version v1.66.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers, please hop on! status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: clear more Mocha and Jest remnants JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg