Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Feature: Also remove existing "mocha" package.json field #1374

Closed
2 tasks done
JoshuaKGoldberg opened this issue Mar 7, 2024 · 1 comment · Fixed by #1607
Closed
2 tasks done

🚀 Feature: Also remove existing "mocha" package.json field #1374

JoshuaKGoldberg opened this issue Mar 7, 2024 · 1 comment · Fixed by #1607
Assignees
Labels
good first issue Good for newcomers, please hop on! status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

Overview

#1372 tracks deleting any existing Mocha options file in a migration... but Mocha can alternately be configured with a "mocha" key in the package.json of a project. Let's have migration also delete that "mocha" in the package.json if it exists.

Additional Info

The logic to remove existing unnecessary fields in a package.json is around here:

// Remove fields we know we don't want, such as old or redundant configs
eslintConfig: undefined,
husky: undefined,
prettierConfig: undefined,
types: undefined,

Similar issue for Jest: #1372

Copy link

github-actions bot commented Aug 7, 2024

🎉 This is included in version v1.66.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers, please hop on! status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant