Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug: husky: install command is deprecated #1437

Closed
3 tasks done
JoshuaKGoldberg opened this issue Mar 30, 2024 · 1 comment · Fixed by #1439
Closed
3 tasks done

🐛 Bug: husky: install command is deprecated #1437

JoshuaKGoldberg opened this issue Mar 30, 2024 · 1 comment · Fixed by #1439
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(

Comments

@JoshuaKGoldberg
Copy link
Owner

JoshuaKGoldberg commented Mar 30, 2024 •
edited
Loading

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

After installing with pnpm i, there should be no unhappy logs.

Actual

After installing with pnpm i:


> [email protected] prepare /Users/josh/repos/create-typescript-app
> husky install

install command is deprecated

Done in 3.5s

Additional Info

I googled a bit and found https://stackoverflow.com/questions/77897612/problem-when-trying-to-add-prettiers-git-hook-husky-install-error-install-com -> https://github.com/typicode/husky/releases/tag/v9.0.1:

Adding husky to a project is now easier than ever. It's just a single line that does the same as above. No need to read the docs to get started anymore.

npx husky init

Okie dokie.
@JoshuaKGoldberg JoshuaKGoldberg added type: bug Something isn't working :( status: accepting prs Please, send a pull request to resolve this! labels Mar 30, 2024
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Mar 30, 2024
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Apr 8, 2024
@JoshuaKGoldberg
fix: replace 'husky install' with just 'husky' (#1439)
4de78e8 
## PR Checklist

- [x] Addresses an existing open issue: fixes #1437
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Looks like all we need to run is `husky` now.
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 8, 2024

🎉 This is included in version v1.57.11 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: replace 'husky install' with just 'husky' JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg