🚀 Feature: Renovate config use preset config:recommended or config:best-practices #1455
Closed
2 tasks done
Labels
status: accepting prs
Please, send a pull request to resolve this!
type: feature
New enhancement or request
Comments
|
Ah, yeah, that would be great. What roughly happened was:
...so this is kind of a step 4: taking the best practices into this repo. Yes please!
Yup! Correct 👍 |
JoshuaKGoldberg
added
the
status: accepting prs
|
@all-contributors please add @rubiesonthesky for ideas.
|
|
I've put up a pull request to add @rubiesonthesky! 🎉 I couldn't determine any contributions to add, did you specify any contributions? |
JoshuaKGoldberg
pushed a commit
that referenced
this issue
Apr 8, 2024
Adds @rubiesonthesky as a contributor for ideas. This was requested by JoshuaKGoldberg [in this comment](#1455 (comment)) --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
This was referenced Apr 11, 2024
JoshuaKGoldberg
added a commit
that referenced
this issue
Apr 26, 2024
## PR Checklist - [x] Addresses an existing open issue: fixes #1455 - [x] That issue was marked as [`status: accepting prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22) - [x] Steps in [CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md) were taken ## Overview Using `config:recommended` for renovate config. `config:best-practices` looked too opinionated for common user, so I think this recommended is better fit. I also added `maintainLockFilesWeekly` and `replacements:all`. I'm not sure if `maintainLockFilesWeekly` is needed when there is pnpm dedupe in every PR already. - maintainLockFilesWeekly: "Run lock file maintenance (updates) early Monday mornings." https://docs.renovatebot.com/presets-default/#maintainlockfilesweekly - replacementsall: "Apply crowd-sourced package replacement rules." https://docs.renovatebot.com/presets-replacements/#replacementsall BTW, some tools seems to be fighting over formatting in this repo. When I save this file in VS code it's formatted differently than what is seen in this PR. So when you stage / commit the file, it gets different formatting. (I re-created this PR because I just learned that using this branch name, you will get renovate validation for free https://docs.renovatebot.com/config-validation/ ) --------- Co-authored-by: Josh Goldberg ✨ <[email protected]>
|
🎉 This is included in version v1.59.0 🎉 The release is available on: Cheers! 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug Report Checklist
mainbranch of the repository.Overview
I propose that renovate config would use present
config:recommendedorconfig:best-practices. https://docs.renovatebot.com/upgrade-best-practices/#general-recommendations General recommendations says to useconfig:best-practicesinstead ofconfig:recommended, but evenconfig:recommendedwould be good to have.This would group monorepos etc together and lessen the spam that renovate easily generates. :)
Additional Info
(I was not sure should this go under feature or tooling, but since this will affect created repositories, I guess this is feature?)
The text was updated successfully, but these errors were encountered: