Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 Feature: Remove padding-line-between-statements ESLint rule #1458

Closed
2 tasks done
JoshuaKGoldberg opened this issue Apr 10, 2024 · 1 comment · Fixed by #1459
Closed
2 tasks done

🚀 Feature: Remove padding-line-between-statements ESLint rule #1458

JoshuaKGoldberg opened this issue Apr 10, 2024 · 1 comment · Fixed by #1459
Assignees
@JoshuaKGoldberg
Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

Overview

https://eslint.org/docs/latest/rules/padding-line-between-statements -> https://typescript-eslint.io/rules/padding-line-between-statements/ is deprecated. And yet I use it in this template. Egads!

Let's just remove it. #493 tracks (re-)adding it to the template by way of the formatter.

Additional Info

https://www.joshuakgoldberg.com/blog/the-blurry-line-between-formatting-and-style
@JoshuaKGoldberg JoshuaKGoldberg added type: feature New enhancement or request status: accepting prs Please, send a pull request to resolve this! labels Apr 10, 2024
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Apr 10, 2024
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Apr 10, 2024
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Apr 10, 2024
@JoshuaKGoldberg
feat: remove no-padding-line-between-statements (#1459)
ce7d3e5 
## PR Checklist

- [x] Addresses an existing open issue: fixes #1458
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Straightforward removal.
@github-actions GitHub Actions
Copy link

🎉 This is included in version v1.59.0 🎉

The release is available on:

Cheers! 📦🚀

@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Aug 10, 2024
Open
3 tasks
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Dec 8, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: remove no-padding-line-between-statements JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg