Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 Feature: Remove the manual disable of no-case-declarations #1467

Closed
2 tasks done
JoshuaKGoldberg opened this issue Apr 15, 2024 · 1 comment · Fixed by #1468
Closed
2 tasks done

🚀 Feature: Remove the manual disable of no-case-declarations #1467

JoshuaKGoldberg opened this issue Apr 15, 2024 · 1 comment · Fixed by #1468
Assignees
@JoshuaKGoldberg
Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Milestone
General Simplific...

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

Overview

I've had a manual disable of https://eslint.org/docs/latest/rules/no-case-declarations in this template for a while. But it doesn't really need to be there. Let's remove it to simplify the config.

Additional Info

I believe I'd added it in out of irritation for not wanting to wrap case statements with {} blocks. But that actually is semantically what the rule is trying to enforce, for some good reasons.
@JoshuaKGoldberg JoshuaKGoldberg added type: feature New enhancement or request status: accepting prs Please, send a pull request to resolve this! labels Apr 15, 2024
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Apr 15, 2024
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Apr 15, 2024
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Apr 15, 2024
@JoshuaKGoldberg
feat: remove disable of no-case-declarations (#1468)
ae44d67 
## PR Checklist

- [x] Addresses an existing open issue: fixes #1467
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Removes the disable of the rule, and adds `{}` blocks around the two
violations in the code base.
@github-actions GitHub Actions
Copy link

🎉 This is included in version v1.59.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Projects
None yet
Milestone
General Simplification
Development

Successfully merging a pull request may close this issue.

feat: remove disable of no-case-declarations JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg