Skip to content

🐛 Bug: Setup script should populate package.json author #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
JoshuaKGoldberg opened this issue Dec 24, 2022 · 0 comments · Fixed by #343
Closed
3 tasks done

🐛 Bug: Setup script should populate package.json author #154

JoshuaKGoldberg opened this issue Dec 24, 2022 · 0 comments · Fixed by #343
Assignees
@JoshuaKGoldberg
Labels
good first issue Good for newcomers, please hop on! status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(

Comments

@JoshuaKGoldberg
Copy link
Owner

JoshuaKGoldberg commented Dec 24, 2022 •
edited
Loading

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

From #147 (comment): after running pnpm setup, the package.json author field should be updated to describe the user who is running setup.

Actual

It stays with the initial value: "author": "Josh Goldberg <[email protected]>",. 😞

Additional Info

The setup script already makes sure the user is authenticated with gh. So you can get information on the user by running gh api user in the script.

const user = JSON.parse(await $`gh api user`);
@JoshuaKGoldberg JoshuaKGoldberg added good first issue Good for newcomers, please hop on! type: bug Something isn't working :( status: accepting prs Please, send a pull request to resolve this! labels Dec 24, 2022
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Mar 30, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Mar 30, 2023
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Mar 30, 2023
@JoshuaKGoldberg
feat: populate package.json author from npm info (#343)
74b1453 
## PR Checklist

- [x] Addresses an existing open issue: fixes #154
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/template-typescript-node-package/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/template-typescript-node-package/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Uses `npm whoami` and
[`npm-user`](https://github.com/sindresorhus/npm-user) to try to
retrieve data on the currently logged in npm user.

Bolsters the end-to-end testing too!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
good first issue Good for newcomers, please hop on! status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: populate package.json author from npm info JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg