Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug: Missing @types/eslint__js #1589

Closed
3 tasks done
JoshuaKGoldberg opened this issue Jul 22, 2024 · 3 comments · Fixed by #1590
Closed
3 tasks done

🐛 Bug: Missing @types/eslint__js #1589

JoshuaKGoldberg opened this issue Jul 22, 2024 · 3 comments · Fixed by #1590
Assignees
@JoshuaKGoldberg
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

Because generated ESLint configs are linted with type information, they should have @types/eslint__js installed as a dev dependency.

Actual

They aren't at the moment.

Additional Info

Reported privately by @FarazPatankar - and then I triggered it updating eslint-plugin-perfectionist in #1588. Fun!

💖

Co-authored-by: @FarazPatankar
@JoshuaKGoldberg JoshuaKGoldberg added type: bug Something isn't working :( status: accepting prs Please, send a pull request to resolve this! labels Jul 22, 2024
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Jul 22, 2024
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Jul 22, 2024
Merged
3 tasks
@JoshuaKGoldberg
Copy link
Owner Author

@allcontributors add @FarazPatankar for bug

@allcontributors allcontributors bot mentioned this issue Jul 22, 2024
Merged
@allcontributors AllContributors
Copy link
Contributor

@JoshuaKGoldberg

I've put up a pull request to add @FarazPatankar! 🎉

@github-actions GitHub Actions
Copy link

🎉 This is included in version v1.62.6 🎉

The release is available on:

Cheers! 📦🚀

JoshuaKGoldberg pushed a commit that referenced this issue Jul 22, 2024
@allcontributors
docs: add FarazPatankar as a contributor for bug (#1591)
dfee927 
Adds @FarazPatankar as a contributor for bug.

This was requested by JoshuaKGoldberg [in this
comment](#1589 (comment))

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add missing @types/eslint__js JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg