Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug: @types/node is needed as devDependency for created projects #1598

Closed
3 tasks done
JoshuaKGoldberg opened this issue Aug 7, 2024 · 1 comment · Fixed by #1599
Closed
3 tasks done

🐛 Bug: @types/node is needed as devDependency for created projects #1598

JoshuaKGoldberg opened this issue Aug 7, 2024 · 1 comment · Fixed by #1599
Assignees
@JoshuaKGoldberg
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(

Comments

@JoshuaKGoldberg
Copy link
Owner

JoshuaKGoldberg commented Aug 7, 2024 •
edited
Loading

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

All devDependencies needed for linting should be installed in new projects.

Actual

@types/node is missed. On new repos:

  52:5   error  Unsafe assignment of an error typed value        @typescript-eslint/no-unsafe-assignment

...which is complaining about import.meta.dirname. That property comes from @types/node.

Additional Info

💖
@JoshuaKGoldberg JoshuaKGoldberg added type: bug Something isn't working :( status: accepting prs Please, send a pull request to resolve this! labels Aug 7, 2024
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Aug 7, 2024
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Aug 7, 2024
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Aug 7, 2024
@JoshuaKGoldberg
fix: also install @types/node in created projects (#1599)
e60808c 
## PR Checklist

- [x] Addresses an existing open issue: fixes #1598
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Adds it in as a `devDependency`.

💖
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 7, 2024

🎉 This is included in version v1.63.1 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: also install @types/node in created projects JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg