Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug: 'common' preset has knip errors upon creation #1635

Closed
3 tasks done
JoshuaKGoldberg opened this issue Aug 15, 2024 · 1 comment · Fixed by #1636
Closed
3 tasks done

🐛 Bug: 'common' preset has knip errors upon creation #1635

JoshuaKGoldberg opened this issue Aug 15, 2024 · 1 comment · Fixed by #1636
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

Running npx create-typescript-app --base common --mode create should create a repo that has no pnpm run lint:knip errors.

Actual

Run pnpm lint:knip

> [email protected] lint:knip /home/runner/work/cta-temp-test/cta-temp-test
> knip

The CJS build of Vite's Node API is deprecated. See https://vitejs.dev/guide/troubleshooting.html#vite-cjs-node-api-deprecated for more details.
Unused devDependencies (4)
@eslint-community/eslint-plugin-eslint-comments  package.json
@types/eslint-plugin-markdown                    package.json
eslint-plugin-jsdoc                              package.json
eslint-plugin-regexp                             package.json
 ELIFECYCLE  Command failed with exit code 1.
Error: Process completed with exit code 1.

sigh

Additional Info

This isn't caught by the end-to-end creation test because that one uses --base everything.

💖
@JoshuaKGoldberg JoshuaKGoldberg added type: bug Something isn't working :( status: accepting prs Please, send a pull request to resolve this! labels Aug 15, 2024
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Aug 15, 2024
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Aug 15, 2024
@JoshuaKGoldberg
fix: remove unnecessary devDependencies for --base common (#1636)
a556755 
## PR Checklist

- [x] Addresses an existing open issue: fixes #1635
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Adds `options.*` checking in `finalizeDependencies`, to better restrict
what gets installed.

💖
@github-actions GitHub Actions
Copy link

🎉 This is included in version v1.71.1 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove unnecessary devDependencies for --base common JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg