Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert add .npmignore to rootfiles #1642

Merged
merged 1 commit into from
Aug 24, 2024
Merged

Conversation

johnnyreilly
Copy link
Collaborator

@johnnyreilly johnnyreilly commented Aug 24, 2024

PR Checklist

Overview

It turns out that .npmignore is not required as TSUP is handling this on our behalf. And we don't publish src because we're not monsters

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

@JoshuaKGoldberg
Copy link
Owner

Sorry for not realizing this sooner!

@JoshuaKGoldberg JoshuaKGoldberg changed the title feat: revert add .npmignore to rootfiles fix: revert add .npmignore to rootfiles Aug 24, 2024
@JoshuaKGoldberg JoshuaKGoldberg merged commit 50f1133 into main Aug 24, 2024
18 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the revert-npm-ignore branch August 24, 2024 17:32
@johnnyreilly
Copy link
Collaborator Author

not a problem!

Copy link

🎉 This is included in version v1.72.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Feature: Test files shouldn't be published
2 participants