-
-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🛠 Tooling: Post release action doesn't work after initial release #1682
Comments
It's weird - if memory serves I followed the instructions for setting up tokens correctly. And it did work the first time. I might dig into it but tbh the post release workflow is "nice to have" stuff - I can live without it. But back to my original question:
Are you finding the same issues on your post release workflows as well? |
@all-contributors please add @johnnyreilly for tool.
|
I've put up a pull request to add @johnnyreilly! 🎉 |
Adds @johnnyreilly as a contributor for tool. This was requested by JoshuaKGoldberg [in this comment](#1682 (comment)) --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Oh, sorry, missed this:
I haven't had this issue. |
Interesting. I've created 2 projects with CTA in the last 3 months and they both have the issue. Mystery as to why though |
Here's two examples of the initial release working on the first attempt but failing on the second: |
It looks that the permissions:
issues: write
pull-requests: write Thanks to @apexskier for the help! As to the "succeeds first time, fails after that" he said:
Take a look at https://github.com/johnnyreilly/azdo-npm-auth/actions/runs/12211680069/job/34069255562 to see the permissions approach working: ![]() And look at the history of this action prior to the addition: ![]() Should the following be added to the permissions:
issues: write
pull-requests: write |
Uh oh! @johnnyreilly, the image you shared is missing helpful alt text. Check #1682 (comment). Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image. Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs. |
Great, accepting PRs to have this in Nice job on the investigation @johnnyreilly. It looks like it was a lot messier than it would have seemed at first. |
<!-- 👋 Hi, thanks for sending a PR to create-typescript-app! 💖. Please fill out all fields below and make sure each item is true and [x] checked. Otherwise we may not be able to review your PR. --> ## PR Checklist - [x] Addresses an existing open issue: fixes #1682 - [x] That issue was marked as [`status: accepting prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22) - [x] Steps in [CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md) were taken ## Overview <!-- Description of what is changed and how the code change does that. --> This PR applies the change suggested by @apexskier here to attempt to fix post-release permissions: apexskier/github-release-commenter#545 (comment)
🎉 This is included in version v1.77.0 🎉 The release is available on: Cheers! 📦🚀 |
Bug Report Checklist
main
branch of the repository.Overview
Consider this post-release GitHub Action: https://github.com/johnnyreilly/ado-npm-auth-lite/actions/workflows/post-release.yml
After the initial run all subsequent runs fail with this error:
Is this a "me" thing? I don't think I've done anything to that and so I'm wondering if I've stumbled on somthing.
Here's the initial successful run: https://github.com/johnnyreilly/ado-npm-auth-lite/actions/runs/11732080037/job/32683543794
Additional Info
n/a
The text was updated successfully, but these errors were encountered: