fix: normalized eslint.config.js ordering and trimming #1723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaKGoldberg
commented
Dec 3, 2024
| { | ||
| extends: [vitest.configs.recommended], | ||
| files: ["**/*.test.*"], | ||
| rules: { | ||
| // These on-by-default rules aren't useful in test files. |
There was a problem hiding this comment.
Removed intentionally. I don't think it was worth the space. This block is clearly for test files, and this list isn't something any project of mine has reasonably added to IIRC.
JoshuaKGoldberg
commented
Dec 3, 2024
| "@typescript-eslint/no-unsafe-assignment": "off", | ||
| "@typescript-eslint/no-unsafe-call": "off", |
There was a problem hiding this comment.
🎉 Very happy that this has since been made unnecessary. I haven't looked deeply, but I'm betting some improvement to Vitest types changed an any to something more precise.
For no-unsafe-assignment, it's down to two any types in Vitest. Filed: vitest-dev/vitest#7015
JoshuaKGoldberg
changed the title
|
🎉 This is included in version v1.77.0 🎉 The release is available on: Cheers! 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
Applies the standard ordering prototyped in #1670. That is, the flat config array elements are in the following order:
ignores(now sorted), thenlinterOptions...s are no longer necessary as of feat(typescript-eslint): allow infinitely deep array nesting in config function and extends typescript-eslint/typescript-eslint#10333files💖