fix: normalized eslint.config.js ordering and trimming #1723
+76
−140
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -24,35 +24,29 @@ import tseslint from "typescript-eslint"; | ||
| export default tseslint.config( | ||
| { | ||
| ignores: [ | ||
| "**/*.snap", | ||
| "coverage*", | ||
| "lib", | ||
| "node_modules", | ||
| "pnpm-lock.yaml", | ||
| ], | ||
| }, | ||
| { linterOptions: { reportUnusedDisableDirectives: "error" } }, | ||
| eslint.configs.recommended, | ||
| comments.recommended, | ||
| jsdoc.configs["flat/contents-typescript-error"], | ||
| jsdoc.configs["flat/logical-typescript-error"], | ||
| jsdoc.configs["flat/stylistic-typescript-error"], | ||
| jsonc.configs["flat/recommended-with-json"], | ||
| markdown.configs.recommended, | ||
| n.configs["flat/recommended"], | ||
| packageJson, | ||
| perfectionist.configs["recommended-natural"], | ||
| regexp.configs["flat/recommended"], | ||
| { | ||
| extends: [ | ||
| tseslint.configs.strictTypeChecked, | ||
| tseslint.configs.stylisticTypeChecked, | ||
| ], | ||
| files: ["**/*.js", "**/*.ts"], | ||
| languageOptions: { | ||
| @@ -94,39 +88,31 @@ export default tseslint.config( | ||
| "object-shorthand": "error", | ||
| "operator-assignment": "error", | ||
| }, | ||
| settings: { perfectionist: { partitionByComment: true, type: "natural" } }, | ||
| }, | ||
| { | ||
| extends: [tseslint.configs.disableTypeChecked], | ||
| files: ["**/*.md/*.ts"], | ||
| }, | ||
| { | ||
| extends: [vitest.configs.recommended], | ||
| files: ["**/*.test.*"], | ||
| rules: { | ||
| "@typescript-eslint/no-unsafe-assignment": "off", | ||
|
There was a problem hiding this comment. 🎉 Very happy that this has since been made unnecessary. I haven't looked deeply, but I'm betting some improvement to Vitest types changed an For |
||
| }, | ||
| }, | ||
| { | ||
| extends: [yml.configs["flat/recommended"], yml.configs["flat/prettier"]], | ||
| files: ["**/*.{yml,yaml}"], | ||
| rules: { | ||
| "yml/file-extension": ["error", { extension: "yml" }], | ||
| "yml/sort-keys": [ | ||
| "error", | ||
| { order: { type: "asc" }, pathPattern: "^.*$" }, | ||
| ], | ||
| "yml/sort-sequence-values": [ | ||
| "error", | ||
| { order: { type: "asc" }, pathPattern: "^.*$" }, | ||
| ], | ||
| }, | ||
| }, | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed intentionally. I don't think it was worth the space. This block is clearly for test files, and this list isn't something any project of mine has reasonably added to IIRC.