Skip to content

🐛 Bug: Default usage receives undefined repository #1826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
JoshuaKGoldberg opened this issue Jan 1, 2025 · 0 comments · Fixed by #1827
Closed
3 tasks done

🐛 Bug: Default usage receives undefined repository #1826

JoshuaKGoldberg opened this issue Jan 1, 2025 · 0 comments · Fixed by #1827
Assignees
@JoshuaKGoldberg
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Milestone
Create Engine Onb...

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

When creating a new repo with npx create typescript-app without an explicit --repository, the inferred usage option should factor in whatever repository option is prompted.

Actual

It's being printed as undefined.

Additional Info

💖
@JoshuaKGoldberg JoshuaKGoldberg added type: bug Something isn't working :( status: accepting prs Please, send a pull request to resolve this! labels Jan 1, 2025
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Jan 1, 2025
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Jan 1, 2025
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Jan 1, 2025
@JoshuaKGoldberg
fix: lazily evaluate options.repository for options.usage (#1827)
777d413 
## PR Checklist

- [x] Addresses an existing open issue: fixes #1826
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Moves `repository` into its own separate `lazyValue` that's then used
for `usage`.

Also allows `repository` to default to `options.directory`.

💖
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Milestone
Create Engine Onboarding
Development

Successfully merging a pull request may close this issue.

fix: lazily evaluate options.repository for options.usage JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg