Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 Feature: Enable @vitest/eslint-config type-checked linting #1847

Closed
2 tasks done
JoshuaKGoldberg opened this issue Jan 14, 2025 · 1 comment · Fixed by #1960
Closed
2 tasks done

🚀 Feature: Enable @vitest/eslint-config type-checked linting #1847

JoshuaKGoldberg opened this issue Jan 14, 2025 · 1 comment · Fixed by #1960
Assignees
@JoshuaKGoldberg
Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

Overview

I'd missed that @vitest/eslint-config has a type-checking option! https://github.com/vitest-dev/eslint-plugin-vitest/?tab=readme-ov-file#enabling-with-type-testing

// eslint.config.js
settings: {
  vitest: {
    typecheck: true
  }
},

I'll want to enable that so that it can properly pick up functions used as test titles. 🚀

Additional Info

💖
@JoshuaKGoldberg JoshuaKGoldberg added type: feature New enhancement or request status: accepting prs Please, send a pull request to resolve this! labels Jan 14, 2025
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Jan 14, 2025
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Mar 6, 2025
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Mar 6, 2025
@JoshuaKGoldberg
feat: enable ESLint settings.vitest.typecheck (#1960)
1320f29 
## PR Checklist

- [x] Addresses an existing open issue: fixes #1847
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Removes quotes from all the `describe()`s I could. Blocks and Inputs
unfortunately are objects, not functions, so they're still not allowed.

🎁
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2025

🎉 This is included in version v2.2.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: enable ESLint settings.vitest.typecheck JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg