Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🛠 Tooling: Use formatIgnoreFile in Blocks that create them #1853

Closed
3 tasks done
JoshuaKGoldberg opened this issue Jan 14, 2025 · 0 comments · Fixed by #1860
Closed
3 tasks done

🛠 Tooling: Use formatIgnoreFile in Blocks that create them #1853

JoshuaKGoldberg opened this issue Jan 14, 2025 · 0 comments · Fixed by #1860
Assignees
@JoshuaKGoldberg
Labels
area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this!

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

In two places, manual .join("\n") instead of formatIgnoreFile() are used:

create-typescript-app/src/next/blocks/blockMarkdownlint.ts

Lines 69 to 76 in 42021fb

".markdownlintignore": [
".github/CODE_OF_CONDUCT.md",
"CHANGELOG.md",
"node_modules/",
...ignores,
]
.sort()
.join("\n"),

create-typescript-app/src/next/blocks/blockPrettier.ts

Lines 99 to 101 in 0da6188

".prettierignore": ["/.husky", "/lib", "/pnpm-lock.yaml", ...ignores]
.sort()
.join("\n"),

I'll reuse formatIgnoreFile.

Additional Info

Prototyped in #1839.

💖
@JoshuaKGoldberg JoshuaKGoldberg added area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! labels Jan 14, 2025
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Jan 14, 2025
This was referenced Jan 14, 2025
Merged
Merged
JoshuaKGoldberg added a commit that referenced this issue Jan 15, 2025
@JoshuaKGoldberg
chore: use formatIgnoreFile in remaining blocks (#1860)
8bd2b02 
## PR Checklist

- [x] Addresses an existing open issue: fixes #1853
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Resists the urge to move the common `.sort()` inside the function, since
not every consumer does that.

💖
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: use formatIgnoreFile in remaining blocks JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg