Skip to content

🐛 Bug: "Are The Types Wrong?" Block includes ? in output GHA #1855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
JoshuaKGoldberg opened this issue Jan 14, 2025 · 0 comments · Fixed by #1858
Closed
3 tasks done

🐛 Bug: "Are The Types Wrong?" Block includes ? in output GHA #1855

JoshuaKGoldberg opened this issue Jan 14, 2025 · 0 comments · Fixed by #1858
Assignees
@JoshuaKGoldberg
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

If blockAreTheTypesWrong is included, it should create a ci.yml workflow with a valid name.

jobs:
  are_the_types_wrong:
    name: Are The Types Wrong?

Actual

I'm seeing it generate:

jobs:
  are_the_types_wrong?:
    name: Are The Types Wrong?

Additional Info

Prototyped in #1839.

💖
@JoshuaKGoldberg JoshuaKGoldberg added type: bug Something isn't working :( status: accepting prs Please, send a pull request to resolve this! labels Jan 14, 2025
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Jan 14, 2025
This was referenced Jan 14, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: remove question marks from GHA job names JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg