Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 Feature: Add packageManager back to the root package.json #1906

Closed
2 tasks done
JoshuaKGoldberg opened this issue Jan 18, 2025 · 3 comments · Fixed by #1961
Closed
2 tasks done

🚀 Feature: Add packageManager back to the root package.json #1906

JoshuaKGoldberg opened this issue Jan 18, 2025 · 3 comments · Fixed by #1961
Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

Overview

Coming over from JoshuaKGoldberg/bingo#145:

Consider adding packageManager to the root package.json, since it was unclear which version of pnpm was needed (I had the wrong one and had to upgrade)

Agreed, it's irksome having to guess which package manager & version to use. You can kind of clue in which package manager it is from the lockfile existing, but that's manual. And the version is very much educated-guesswork.

Additional Info

This actually used to exist in this repo, but I removed it:

  1. 🐛 Bug: Crash in --mode create if pnpm version mismatches  #1513
  2. fix: remove package.json packageManager field #1529

This was discussed in pnpm/pnpm#8087, and at the time of #1529, still open - hence the removing of the field in this repo. It was later resolved in pnpm/pnpm#8166. Phew! So we are unblocked in this repo.

🎁

Co-authored-by: @boneskull
@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request labels Jan 18, 2025
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Jan 18, 2025
Closed
@JoshuaKGoldberg
Copy link
Owner Author

@all-contributors please add @boneskull for ideas.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

@allcontributors allcontributors bot mentioned this issue Jan 26, 2025
Merged
@allcontributors AllContributors
Copy link
Contributor

@JoshuaKGoldberg

I've put up a pull request to add @boneskull! 🎉

JoshuaKGoldberg added a commit that referenced this issue Jan 27, 2025
@allcontributors @JoshuaKGoldberg
docs: add boneskull as a contributor for ideas (#1915)
d72b232 
Adds @boneskull as a contributor for ideas.

This was requested by JoshuaKGoldberg [in this
comment](#1906 (comment))

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Co-authored-by: Josh Goldberg <[email protected]>
This was referenced Mar 2, 2025
Open
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2025

🎉 This is included in version v2.2.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Projects
None yet
Milestone
No milestone
1 participant
@JoshuaKGoldberg