Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add packageManager back to package.json, and set to pnpm 10.4.0 in CI #1961

Merged
merged 4 commits into from
Mar 6, 2025

Conversation

JoshuaKGoldberg
Copy link
Owner

PR Checklist

Overview

Adds a pnpm option to the Base, which defaults to the existing packageManager's pnpm version if it exists.

🎁

@JoshuaKGoldberg JoshuaKGoldberg changed the title feat: add packageManager back to package.json feat: add packageManager back to package.json, and set to pnpm 10 in CI Mar 6, 2025
@JoshuaKGoldberg JoshuaKGoldberg changed the title feat: add packageManager back to package.json, and set to pnpm 10 in CI feat: add packageManager back to package.json, and set to pnpm 10.4.0 in CI Mar 6, 2025
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.

Project coverage is 95.43%. Comparing base (1320f29) to head (4a9f6b7).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/base.ts 81.81% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1961      +/-   ##
==========================================
- Coverage   95.47%   95.43%   -0.04%     
==========================================
  Files          89       89              
  Lines        3622     3635      +13     
  Branches      210      213       +3     
==========================================
+ Hits         3458     3469      +11     
- Misses        164      166       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JoshuaKGoldberg
Copy link
Owner Author

Test timeout. Amusing.

@JoshuaKGoldberg JoshuaKGoldberg merged commit f9c230c into main Mar 6, 2025
10 of 11 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the add-packagemanager-back branch March 6, 2025 15:27
Copy link

github-actions bot commented Mar 6, 2025

🎉 This is included in version v2.2.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Feature: Add packageManager back to the root package.json
1 participant