Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only PUT a ruleset when an ID already exists #1968

Merged
merged 1 commit into from
Mar 7, 2025

Conversation

JoshuaKGoldberg
Copy link
Owner

PR Checklist

Overview

If options.rulesetId doesn't exist, then transition mode should still POST a new ruleset, not PUT to update an existing one.

🎁

@JoshuaKGoldberg JoshuaKGoldberg merged commit 784dfbb into main Mar 7, 2025
12 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the block-ruleset-only-put-with-option branch March 7, 2025 00:31
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 20.51282% with 62 lines in your changes missing coverage. Please review.

Project coverage is 94.85%. Comparing base (5dd93c0) to head (29a7c28).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/blocks/blockRepositoryBranchRuleset.ts 20.51% 62 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1968      +/-   ##
==========================================
- Coverage   95.55%   94.85%   -0.70%     
==========================================
  Files          91       91              
  Lines        3643     3655      +12     
  Branches      214      214              
==========================================
- Hits         3481     3467      -14     
- Misses        162      188      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

github-actions bot commented Mar 7, 2025

🎉 This is included in version v2.4.1 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: Occasional error in transition mode: The branch-ruleset-update request failed
1 participant