Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🛠 Tooling: Finish porting Base options preparation to Bingo Inputs #1973

Closed
3 tasks done
JoshuaKGoldberg opened this issue Mar 7, 2025 · 1 comment · Fixed by #1985
Closed
3 tasks done

🛠 Tooling: Finish porting Base options preparation to Bingo Inputs #1973

JoshuaKGoldberg opened this issue Mar 7, 2025 · 1 comment · Fixed by #1985
Labels
area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this!

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

Right now, the prepare() method in CTA's Base uses proper Bingo Inputs via take only for some values:

const nvmrc = lazyValue(
async () =>
await take(inputFromFile, {
filePath: ".nvmrc",
}),
);

Others are still marked under a TODO to switch to using take:

// TODO: Make these all use take
const gitDefaults = tryCatchLazyValueAsync(async () =>
gitUrlParse(await gitRemoteOriginUrl()),
);

It'll be good to switch everything over to using the proper take Input plumbing.

Additional Info

This'll also make the function easier to test. Which I would like to do more of. It's only around 90% tested right now: https://app.codecov.io/gh/JoshuaKGoldberg/create-typescript-app/blob/e6402c6397db1484402f82fe15498a2d7cee6126/src%2Fbase.ts

🎁

Copy link

🎉 This is included in version v2.6.1 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this!
Projects
None yet
1 participant