Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: refactor Base options to (mostly) properly use Bingo Inputs #1985

Merged
merged 6 commits into from
Mar 18, 2025

Conversation

JoshuaKGoldberg
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg commented Mar 17, 2025

PR Checklist

Overview

Migrates the existing options over when possible. A couple are based on external packages that aren't easy to stub out external dependencies for. Those can be followup issues.

Now, base.ts generally contains a more consistent pattern with naming:

  • get* are lazyValue(async () => await read*(...)) functions for each value
  • read* are async functions that take in any number of get*s to compute a value

Also removes an unused logic field while I'm here.

This is a fix: because it adds better handling for running without a reliable internet connection:

  • npm whoami --offline to stop a minute of internal retries
  • request: { retries: 0 } on inputFromOctkit to stop its retries too

🎁

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

Copy link

codecov bot commented Mar 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.92%. Comparing base (20ab241) to head (366fda4).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1985      +/-   ##
==========================================
+ Coverage   99.11%   99.92%   +0.81%     
==========================================
  Files          93      106      +13     
  Lines        4061     4187     +126     
  Branches      232      253      +21     
==========================================
+ Hits         4025     4184     +159     
+ Misses         36        3      -33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JoshuaKGoldberg JoshuaKGoldberg changed the title chore: refactor Base options to (mostly) properly use Bingo Inputs fix: refactor Base options to (mostly) properly use Bingo Inputs Mar 18, 2025
@JoshuaKGoldberg JoshuaKGoldberg merged commit 963df5a into main Mar 18, 2025
17 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the base-options branch March 18, 2025 02:28
Copy link

🎉 This is included in version v2.6.1 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🛠 Tooling: Finish porting Base options preparation to Bingo Inputs
1 participant