Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🛠 Tooling: Figure out how to test email transforms #1991

Open
3 tasks done
JoshuaKGoldberg opened this issue Mar 18, 2025 · 0 comments
Open
3 tasks done

🛠 Tooling: Figure out how to test email transforms #1991

JoshuaKGoldberg opened this issue Mar 18, 2025 · 0 comments
Labels
area: tooling Managing the repository's maintenance status: blocked Waiting for something else to be resolved

Comments

@JoshuaKGoldberg
Copy link
Owner

JoshuaKGoldberg commented Mar 18, 2025 •
edited
Loading

Tooling Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

One of the few still-untested pieces of logic in CTA is the transform of email on the CLI:

create-typescript-app/src/base.ts

Lines 72 to 83 in 666e3fa

email: z
.union([
z.string(),
z.object({
github: z.string(),
npm: z.string(),
}),
])
// TODO: Test this? Is it still working?
.transform((email) =>
typeof email === "string" ? { github: email, npm: email } : email,
)

I don't know how to test this with Bingo. But it'd be good to get this tested.

Additional Info

Blocked on upstream issue to figure this out: JoshuaKGoldberg/bingo#294

🎁
@JoshuaKGoldberg JoshuaKGoldberg added the area: tooling Managing the repository's maintenance label Mar 18, 2025
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Mar 18, 2025
Open
2 tasks
@JoshuaKGoldberg JoshuaKGoldberg added the status: blocked Waiting for something else to be resolved label Mar 18, 2025
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Mar 18, 2025
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Mar 18, 2025
@JoshuaKGoldberg
fix: use standard packages or link to issues for remaining code TODOs (…
855c1da 
…#1994)

## PR Checklist

- [x] Addresses an existing open issue: fixes #1987
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Cleans up some pending code TODOs:

* Bumping `@vitest/eslint-plugin` to include
vitest-dev/eslint-plugin-vitest#682
* Refactors `retGitDefaults` to execute a straightforward `git remote
get-url origin` instead of the full `git-remote-origin-url`
* Uses [`sort-keys`](http://npmjs.com/package/sort-keys) instead of the
ad-hoc internal `sortKeys`
* Uses [`zod-package-json`](http://npmjs.com/package/zod-package-json)
instead of a manually written schema

Otherwise doesn't change behavior, instead adding links to:

* #1990
* #1991
* #1992
* #1993

🎁
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: tooling Managing the repository's maintenance status: blocked Waiting for something else to be resolved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JoshuaKGoldberg