Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: preserve existing package.json dependency versions as minimums #1999

Merged
merged 2 commits into from
Mar 21, 2025

Conversation

JoshuaKGoldberg
Copy link
Owner

PR Checklist

Overview

Uses the semver package to avoid using new dependency versions if they're smaller than existing ones.

As a nice-to-have, not-strictly-necessary cleanup, removes the Base distinction between "full" package data and what's used in Blocks. It's just packageData now. No more packageDataFull.

🎁

Copy link

codecov bot commented Mar 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.92%. Comparing base (841dacc) to head (03b4297).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1999   +/-   ##
=======================================
  Coverage   99.92%   99.92%           
=======================================
  Files         106      105    -1     
  Lines        4183     4191    +8     
  Branches      253      261    +8     
=======================================
+ Hits         4180     4188    +8     
  Misses          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review March 21, 2025 12:02
@JoshuaKGoldberg JoshuaKGoldberg merged commit 4b1d084 into main Mar 21, 2025
13 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the package-json-preserve-dep-minimums branch March 21, 2025 12:34
Copy link

🎉 This is included in version v2.7.3 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: Transition mode should not lower package.json dependency versions
1 participant