Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug: .allcontributorsrc is conflicting with formatting again #2001

Closed
3 tasks done
JoshuaKGoldberg opened this issue Mar 21, 2025 · 1 comment · Fixed by #2004
Closed
3 tasks done

🐛 Bug: .allcontributorsrc is conflicting with formatting again #2001

JoshuaKGoldberg opened this issue Mar 21, 2025 · 1 comment · Fixed by #2004
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(

Comments

@JoshuaKGoldberg
Copy link
Owner

JoshuaKGoldberg commented Mar 21, 2025 •
edited
Loading

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

PRs generated by the @allcontributors bot shouldn't mangle formatting. The file should be formatted with tabs per the Prettier config.

Actual

#1974 is replacing tabs with spaces.

JoshuaKGoldberg/all-contributors-for-repository#773 is an example in a downstream repo.

Additional Info

Sigh. I've seen this before. Similar past issue: #837

🎁
@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :( labels Mar 21, 2025
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Mar 21, 2025
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Mar 21, 2025
Closed
@JoshuaKGoldberg JoshuaKGoldberg removed their assignment Mar 21, 2025
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Mar 21, 2025
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Mar 21, 2025
@JoshuaKGoldberg
fix: add /.all-contributorsrc back to .prettierignore again (#2004)
451db09 
## PR Checklist

- [x] Addresses an existing open issue: fixes #2001
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Similar to #838.

🎁
@github-actions GitHub Actions
Copy link

🎉 This is included in version v2.8.1 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add /.all-contributorsrc back to .prettierignore again JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg