Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Feature: More aggressively remove past CTA settings in Block transitions #2002

Closed
2 tasks done
JoshuaKGoldberg opened this issue Mar 21, 2025 · 1 comment · Fixed by #2003
Closed
2 tasks done
Assignees
Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request

Comments

@JoshuaKGoldberg
Copy link
Owner

Feature Request Checklist

Overview

Coming over from JoshuaKGoldberg/all-contributors-for-repository#772: I've noticed there are a lot of old things from past versions of CTA, both in 1.x and 2.x, that don't get removed in transition mode. I'll collect those and add them in as a feature.

Examples:

  • Removing devDependencies: @types/eslint, jsonc-eslint-parser, ...
  • Removing old files: .github/workflows/lint-knip.yml, knip.jsonc, ...

Additional Info

🎁

@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request labels Mar 21, 2025
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Mar 21, 2025
JoshuaKGoldberg added a commit that referenced this issue Mar 24, 2025
<!-- 👋 Hi, thanks for sending a PR to create-typescript-app! 🎁.
Please fill out all fields below and make sure each item is true and [x]
checked.
Otherwise we may not be able to review your PR. -->

## PR Checklist

- [x] Addresses an existing open issue: fixes #2002
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Adds a collection of dependency and file cleanups based on older CTA
versions.

Also unifies their removals into new `blockRemoveDependencies` and
`blockRemoveFiles` Blocks. This should actually speed things up by
running one command for each of those two Blocks. Previously it was one
command for each Block with things to remove.

🎁
Copy link

🎉 This is included in version v2.9.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant