Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add more transition mode cleanups #2003

Merged
merged 14 commits into from
Mar 24, 2025

Conversation

JoshuaKGoldberg
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg commented Mar 21, 2025

PR Checklist

Overview

Adds a collection of dependency and file cleanups based on older CTA versions.

Also unifies their removals into new blockRemoveDependencies and blockRemoveFiles Blocks. This should actually speed things up by running one command for each of those two Blocks. Previously it was one command for each Block with things to remove.

🎁

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
JoshuaKGoldberg Josh Goldberg ✨

Verified

This commit was signed with the committer’s verified signature.
JoshuaKGoldberg Josh Goldberg ✨

Verified

This commit was signed with the committer’s verified signature.
JoshuaKGoldberg Josh Goldberg ✨

Verified

This commit was signed with the committer’s verified signature.
JoshuaKGoldberg Josh Goldberg ✨

Verified

This commit was signed with the committer’s verified signature.
JoshuaKGoldberg Josh Goldberg ✨
@JoshuaKGoldberg JoshuaKGoldberg changed the title More transitioning cleanups feat: add more transition mode cleanups Mar 21, 2025

Verified

This commit was signed with the committer’s verified signature.
JoshuaKGoldberg Josh Goldberg ✨

Verified

This commit was signed with the committer’s verified signature.
JoshuaKGoldberg Josh Goldberg ✨

Verified

This commit was signed with the committer’s verified signature.
JoshuaKGoldberg Josh Goldberg ✨

Verified

This commit was signed with the committer’s verified signature.
JoshuaKGoldberg Josh Goldberg ✨
@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review March 21, 2025 20:05

Verified

This commit was signed with the committer’s verified signature.
JoshuaKGoldberg Josh Goldberg ✨

Verified

This commit was signed with the committer’s verified signature.
JoshuaKGoldberg Josh Goldberg ✨
Copy link

codecov bot commented Mar 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.93%. Comparing base (451db09) to head (80ae93d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #2003    +/-   ##
========================================
  Coverage   99.92%   99.93%            
========================================
  Files         106      108     +2     
  Lines        4265     4367   +102     
  Branches      261      265     +4     
========================================
+ Hits         4262     4364   +102     
  Misses          3        3            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Verified

This commit was signed with the committer’s verified signature.
JoshuaKGoldberg Josh Goldberg ✨

Verified

This commit was signed with the committer’s verified signature.
JoshuaKGoldberg Josh Goldberg ✨

Verified

This commit was signed with the committer’s verified signature.
JoshuaKGoldberg Josh Goldberg ✨
@JoshuaKGoldberg JoshuaKGoldberg merged commit c179a7e into main Mar 24, 2025
20 of 21 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the more-transitioning-cleanups branch March 24, 2025 21:42
Copy link

🎉 This is included in version v2.9.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Feature: More aggressively remove past CTA settings in Block transitions
1 participant