Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Feature: Disable previous main branch protection in transition mode #2016

Closed
2 tasks done
JoshuaKGoldberg opened this issue Mar 25, 2025 · 1 comment · Fixed by #2028
Closed
2 tasks done

🚀 Feature: Disable previous main branch protection in transition mode #2016

JoshuaKGoldberg opened this issue Mar 25, 2025 · 1 comment · Fixed by #2028
Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request

Comments

@JoshuaKGoldberg
Copy link
Owner

Feature Request Checklist

Overview

As of #1309 -> #1788, this template uses GitHub repository rulesets instead of branch protections. But older repos made with the template may still be using a main branch protection.

Let's have blockRepositoryBranchRuleset send a request to disable any existing main branch protection as part of its transition().

Additional Info

If possible, it'd be good to disable and not delete the branch protection. Just in case there was something there folks wanted.

🎁

@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request labels Mar 25, 2025
JoshuaKGoldberg added a commit that referenced this issue Mar 26, 2025
#2028)

## PR Checklist

- [x] Addresses an existing open issue: fixes #2016
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Includes updates to the latest Bingo packages to bring in silent
requests: JoshuaKGoldberg/bingo#313

I would have liked to go with a rename or archive kind of API, even
changing the protection to be on some branch like `main-prior-to-cta`.
But such a GitHub API does not exist. 🤷

🎁
Copy link

🎉 This is included in version v2.14.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Projects
None yet
1 participant