Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 Feature: Add a 'flags' Addon to blockVitest #2071

Closed
2 tasks done
JoshuaKGoldberg opened this issue Mar 31, 2025 · 1 comment · Fixed by #2072
Closed
2 tasks done

🚀 Feature: Add a 'flags' Addon to blockVitest #2071

JoshuaKGoldberg opened this issue Mar 31, 2025 · 1 comment · Fixed by #2072
Assignees
@JoshuaKGoldberg
Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Milestone
Transition Mode D...

Comments

@JoshuaKGoldberg
Copy link
Owner

Feature Request Checklist

Overview

Vitest's --typecheck is not on by default. Repos that want to enable Vitest's Testing Types must do so manually. Example from https://github.com/JoshuaKGoldberg/without-undefined-properties/blob/0649947e48595ba47ae6d9dfb3df667fa0c2bf3e/package.json#L31:

"test": "vitest --typecheck",

For now, I'll add an Addon to blockVitest to allow specifying extra CLI flags to the "test" script.

Additional Info

vitest-dev/vitest#7773 tracks the feature request on Vitest to turn on --typecheck by default.
@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request labels Mar 31, 2025
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Mar 31, 2025
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Mar 31, 2025
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Mar 31, 2025
@JoshuaKGoldberg
feat: add flags Addon to blockVitest (#2072)
1560d0f 
## PR Checklist

- [x] Addresses an existing open issue: fixes #2071
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

🎁
@github-actions GitHub Actions
Copy link

🎉 This is included in version v2.19.0 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Projects
None yet
Milestone
Transition Mode Dogfooding
Development

Successfully merging a pull request may close this issue.

feat: add flags Addon to blockVitest JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg