Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug: blockTypeScript should print compilerOptions in alphabetical order #2092

Closed
3 tasks done
JoshuaKGoldberg opened this issue Apr 2, 2025 · 1 comment · Fixed by #2104
Closed
3 tasks done

🐛 Bug: blockTypeScript should print compilerOptions in alphabetical order #2092

JoshuaKGoldberg opened this issue Apr 2, 2025 · 1 comment · Fixed by #2104
Assignees
@JoshuaKGoldberg
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Milestone
Transition Mode D...

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

If a user provides explicit compilerOption Addons to blockTypeScript, then they should be merged in with existing compiler options in alphabetical order.

Actual

https://github.com/JoshuaKGoldberg/package-json-validator/pull/178/files#diff-b55cdbef4907b7045f32cc5360d48d262cca5f94062e353089f189f4460039e0 shows that a provided rewriteRelativeImportExtensions is being placed at the end - after t* options.

Additional Info

🎁
@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :( labels Apr 2, 2025
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Apr 2, 2025
This was referenced Apr 2, 2025
Merged
Merged
JoshuaKGoldberg added a commit that referenced this issue Apr 2, 2025
@JoshuaKGoldberg
fix: sort compilerOptions in tsconfig.json (#2104)
c56f78a 
## PR Checklist

- [x] Addresses an existing open issue: fixes #2092
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [ ] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

🎁
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 2, 2025

🎉 This is included in version v2.22.7 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Milestone
Transition Mode Dogfooding
Development

Successfully merging a pull request may close this issue.

fix: sort compilerOptions in tsconfig.json JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg