Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug: blockPackageJson ignores addons.type if provided #2109

Closed
3 tasks done
JoshuaKGoldberg opened this issue Apr 2, 2025 · 1 comment · Fixed by #2110
Closed
3 tasks done

🐛 Bug: blockPackageJson ignores addons.type if provided #2109

JoshuaKGoldberg opened this issue Apr 2, 2025 · 1 comment · Fixed by #2110
Assignees
@JoshuaKGoldberg
Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Milestone
Transition Mode D...

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Expected

This should customize the generated package.json's type:

blockPackageJson({
	properties: {
		type: "commonjs",
	},
}),

Actual

https://github.com/JoshuaKGoldberg/package-json-validator/pull/178/files#r2025641061 shows a package.json with a type forcefully set to "module".

Additional Info

🎁
@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :( labels Apr 2, 2025
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Apr 2, 2025
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Apr 2, 2025
Merged
3 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 2, 2025

🎉 This is included in version v2.22.11 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Milestone
Transition Mode Dogfooding
Development

Successfully merging a pull request may close this issue.

fix: allow overriding package.json type JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg