fix: allow overriding package.json type #2110
Merged
+28
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2110 +/- ##
=======================================
Coverage 99.80% 99.80%
=======================================
Files 127 127
Lines 5214 5214
Branches 361 361
=======================================
Hits 5204 5204
Misses 10 10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
🎉 This is included in version v2.22.11 🎉 The release is available on: Cheers! 📦🚀 |
JoshuaKGoldberg
added a commit
that referenced
this pull request
Apr 3, 2025
## PR Checklist - [x] Addresses an existing open issue: fixes #2111 - [x] That issue was marked as [`status: accepting prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22) - [x] Steps in [CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md) were taken ## Overview Goes a different, more comprehensive direction than #2110. Instead of encouraging a `blockPackageJson` it promotes `type` to a top-level option. `--type commonjs` will now work if a user really wants. `blockESLint` will now print its config as `eslint.config.mjs` if `options.type` is `"commonjs"`. It's still `eslint.config.js` otherwise. 🎁
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
blockPackageJsonignoresaddons.typeif provided #2109status: accepting prsOverview
🎁