New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug: .eslint-doc-generatorrc.js should be .mjs in CJS packages #2137

Closed

3 tasks done

JoshuaKGoldberg opened this issue Apr 4, 2025 · 1 comment

Closed

3 tasks done

🐛 Bug: .eslint-doc-generatorrc.js should be .mjs in CJS packages #2137

JoshuaKGoldberg opened this issue Apr 4, 2025 · 1 comment

Assignees

Labels

status: accepting prs type: bug

Milestone

Transition Mode D...

Owner

JoshuaKGoldberg commented Apr 4, 2025

Bug Report Checklist

I have tried restarting my IDE and the issue persists.
I have pulled the latest main branch of the repository.
I have searched for related issues and found none that matched my issue.

Expected

The blockESLintPlugin config file's type should be a .mjs when the package.json specifies "type": "commonjs".

Actual

JoshuaKGoldberg/eslint-plugin-package-json#993 (comment): it's still .js.

Additional Info

🎁

The text was updated successfully, but these errors were encountered:

JoshuaKGoldberg added status: accepting prs type: bug labels

JoshuaKGoldberg added this to the Transition Mode Dogfooding milestone

JoshuaKGoldberg self-assigned this

JoshuaKGoldberg mentioned this issue

fix: correct blockESLintPlugin peerDependencies and config file name #2138

Merged

3 tasks

JoshuaKGoldberg added a commit that referenced this issue


          fix: correct blockESLintPlugin peerDependencies and config file name (#…

4f3b211

…2138)

## PR Checklist

- [x] Addresses an existing open issue: fixes #2134, #2137
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

🎁

Owner Author

JoshuaKGoldberg commented Apr 4, 2025

Fixed by #2138.

JoshuaKGoldberg closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment